linux-kernel - Re: [PATCH] selftests/futex: Fix makefile dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1d63ba6-6942-6b22-04b4-9aed1196da89@kernel.org>
Date:   Wed, 11 Jan 2017 07:41:07 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     Stafford Horne <shorne@...il.com>,
        Darren Hart <dvhart@...radead.org>
Cc:     linux-kernel@...r.kernel.org, dvhart@...ux.intel.com,
        linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests/futex: Fix makefile dependencies

On 01/11/2017 01:48 AM, Stafford Horne wrote:
> On Wed, Jan 11, 2017 at 12:07:55AM -0800, Darren Hart wrote:
>> On Wed, Jan 11, 2017 at 01:37:19PM +0900, Stafford Horne wrote:
>>> On Tue, Jan 10, 2017 at 02:17:18PM -0800, Darren Hart wrote:
>>>> On Tue, Jan 10, 2017 at 02:10:42PM -0800, Darren Hart wrote:
>>>>> On Fri, Jan 06, 2017 at 01:18:39PM +0900, Stafford Horne wrote:
>>>>>> I am working on doing selftests for openrisc and found issues with the
>>>>>> futex test is not building after changes to the tests source.
>>>>>>
>>>>>> This issue is that the TARGETS variable used in the futex Makefile is
>>>>>> also used by the selftests Makefile, so when building from toplevel the
>>>>>> TARGETS variable is clobbered and nothing gets built. Changed the
>>>>>> variable name to get around that.
>>>>>>
>>>>>> Also, the futex makefile did not contain dependencies for all headers,
>>>>>> so if we make changes to logging.h rebuild will not happen. Add headers
>>>>>> to fix it up.
>>>>>>
>>>>>> Signed-off-by: Stafford Horne <shorne@...il.com>
>>>>>
>>>>> Thanks for catching this and the fix.
>>>>>
>>>>> +Shuah Khan
>>>>>
>>>>> Note: This appears also to be a problem for intel_pstate/Makefile
>>>>
>>>> Or, it would be if intel_pstate was listed in selftests/Makefile :-)
>>>
>>> Right, thanks for having a look.  I actually have a small patch to also
>>> add <stdio.h> to logging.h.  If you have not already fixed the
>>> intel_pstate test I'll send them all together.
>>
>> Please do, thanks!
> 
> Hello,
> Actually I just had a look at Shuah's linux-kselftest repo on
> kernel.org. It looks like Bamvor Jian has actually fixed a lot of these
> issues on the next branch.
> 
> I will see what is missing if anything.
> 
> -Stafford
> 
> 

Hi Stafford,

Thanks for looking into the issues. Yes Bemovar fixed several issues.
Could you please send me the patches you alre

If you think [PATCH] selftests/futex: Fix makefile dependencies
should be pulled in, please send it to me. I just Darren's response,
don't have the original patch email in my Inbox.

thanks,
-- Shuah