linux-kernel - Re: [PATCH v2] net: netcp: correct netcp_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2017 10:48:45 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     j-keerthy@...com
Cc:     w-kwok2@...com, m-karicheri2@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stephen@...workplumber.org,
        m-scherban@...com
Subject: Re: [PATCH v2] net: netcp: correct netcp_get_stats function
 signature

From: Keerthy <j-keerthy@...com>
Date: Wed, 11 Jan 2017 09:03:29 +0530

> Commit: bc1f44709cf2 - net: make ndo_get_stats64 a void function
> and
> Commit: 6a8162e99ef3 - net: netcp: store network statistics in 64 bits.
> 
> The commit 6a8162e99ef3 adds ndo_get_stats64 function as per old
> signature which causes compilation error:
> 
> drivers/net/ethernet/ti/netcp_core.c:1951:28: error:
> initialization from incompatible pointer type
>   .ndo_get_stats64        = netcp_get_stats,
> 
> Hence correct netcp_get_stats function signature as per
> the latest definition.
> 
> Signed-off-by: Keerthy <j-keerthy@...com>
> Fixes: 6a8162e99ef344fc("net: netcp: store network statistics in 64 bits")

Applied, thanks.