linux-kernel - Re: [PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h37gpy33x.wl-tiwai@suse.de>
Date:   Wed, 11 Jan 2017 17:26:42 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use

On Wed, 11 Jan 2017 14:39:44 +0100,
Arnd Bergmann wrote:
> 
> gcc-7 caught what it considers a NULL pointer dereference:
> 
> sound/pci/hda/patch_ca0132.c: In function 'dspio_scp.constprop':
> sound/pci/hda/patch_ca0132.c:1487:4: error: argument 1 null where non-null expected [-Werror=nonnull]
> 
> This is plausible from looking at the function, as we compare 'reply'
> to NULL earlier in it. I have not tried to analyze if there are constraints
> that make it impossible to hit the bug, but adding another NULL check in
> the end kills the warning and makes the function more robust.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.


Takashi