linux-kernel - Re: [PATCH] regulator: core: Don't use regulators as supplies until the parent is bound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d9b2cf5-55ef-f389-3381-da101bda7db5@nvidia.com>
Date:   Wed, 11 Jan 2017 16:57:18 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] regulator: core: Don't use regulators as supplies until
 the parent is bound


On 10/01/17 16:57, Mark Brown wrote:
> * PGP Signed by an unknown key
> 
> On Tue, Jan 10, 2017 at 11:01:09AM +0000, Jon Hunter wrote:
> 
>> +++ b/drivers/regulator/core.c
>> @@ -1553,6 +1553,11 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
>>  		}
>>  	}
>>  
>> +	if (r->dev.parent && !device_is_bound(r->dev.parent)) {
>> +		put_device(&r->dev);
>> +		return -EPROBE_DEFER;
>> +	}
>> +
> 
> I realised earlier that this will trigger when the supply and the
> consumer are part of the same PMIC which will cause issues as that's a
> fairly common setup and won't be resolved by deferring.  Can you please
> modify this to only defer if the parent is not the same as the parent of
> the regulator we're currently resolving?  Sorry, should've thought of
> this yesterday.

OK, no problem. Will send out an update shortly.

Cheers
Jon

-- 
nvpublic