lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Jan 2017 01:14:50 +0100 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Bhumika Goyal <bhumirks@...il.com> Cc: julia.lawall@...6.fr, a.zummo@...ertech.it, rtc-linux@...glegroups.com, adi-buildroot-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] rtc: add const to rtc_class_ops structures On 05/01/2017 at 22:48:37 +0530, Bhumika Goyal wrote : > Declare rtc_class_ops structures as const as they are only passed > as an argument to the function devm_rtc_device_register. This argument > is of type const struct rtc_class_ops *, so rtc_class_ops structures > having this property can be declared const. > Done using Coccinelle: > > @r1 disable optional_qualifier @ > identifier i; > position p; > @@ > static struct rtc_class_ops i@p = {...}; > > @ok1@ > identifier r1.i; > position p; > @@ > devm_rtc_device_register(...,&i@p,...) > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct rtc_class_ops i; > > Signed-off-by: Bhumika Goyal <bhumirks@...il.com> > --- > Compilation was terminated while compiling the .o files for all the > changed .c files. Therefore file size details of the .o files > could not be obtained. > > drivers/rtc/rtc-au1xxx.c | 2 +- > drivers/rtc/rtc-bfin.c | 2 +- > drivers/rtc/rtc-ls1x.c | 2 +- > drivers/rtc/rtc-sh.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > Applied and squashed in the previous one. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists