linux-kernel - [PATCH v2] staging: most: hdm-usb: Fix mismatch between types used in sizeof operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2017 19:38:35 -0600
From:   Eric Salem <ericsalem@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     christian.gromm@...rochip.com, andrey.shvetsov@....de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2] staging: most: hdm-usb: Fix mismatch between types used in
 sizeof operator

Fixed mismatch between types used in sizeof operator.

Signed-off-by: Eric Salem <ericsalem@...il.com>
---
 drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
index 8a6da16..01e3a31 100644
--- a/drivers/staging/most/hdm-usb/hdm_usb.c
+++ b/drivers/staging/most/hdm-usb/hdm_usb.c
@@ -145,7 +145,7 @@ static void wq_netinfo(struct work_struct *wq_obj);
 static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf)
 {
 	int retval;
-	__le16 *dma_buf = kzalloc(sizeof(__le16), GFP_KERNEL);
+	__le16 *dma_buf = kzalloc(sizeof(*dma_buf), GFP_KERNEL);
 	u8 req_type = USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE;
 
 	if (!dma_buf)
@@ -154,7 +154,7 @@ static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf)
 	retval = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0),
 				 DRCI_READ_REQ, req_type,
 				 0x0000,
-				 reg, dma_buf, sizeof(u16), 5 * HZ);
+				 reg, dma_buf, sizeof(*dma_buf), 5 * HZ);
 	*buf = le16_to_cpu(*dma_buf);
 	kfree(dma_buf);
 
-- 
2.9.3

On 01/10/2017 10:40 AM, Greg KH wrote:
> On Mon, Jan 09, 2017 at 09:25:56PM -0600, Eric Salem wrote:
>> Fixed the following sparse warning:
>>
>> drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning:
>> cast to restricted __le16
>>
>> by correcting the variable's type (also updated sizeof).
>>
>> Signed-off-by: Eric Salem <ericsalem@...il.com>
>> Acked-by: Christian Gromm <christian.gromm@...rochip.com>
>> ---
>>  drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> This patch doesn't apply against linux-next, can you refresh it and
> resend?
> 
> thanks,
> 
> greg k-h
>