linux-kernel - Re: [PATCH 1/5] perf, tools: Add probing for xed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170111183714.GB29004@krava>
Date:   Wed, 11 Jan 2017 19:37:14 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     acme@...nel.org, jolsa@...nel.org, mingo@...nel.org,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed

On Mon, Jan 09, 2017 at 05:02:21PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> Add autoprobing for the xed disassembler library.
> 
> Can be downloaded from https://github.com/intelxed/xed
> 
> v2: Hide. Require XED=1 to enable. Add XED_DIR
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  tools/build/Makefile.feature   |  8 +++++---
>  tools/build/feature/Makefile   |  8 ++++++--
>  tools/build/feature/test-all.c |  5 +++++
>  tools/build/feature/test-xed.c |  9 +++++++++
>  tools/perf/Makefile.config     | 16 ++++++++++++++++
>  tools/perf/Makefile.perf       |  3 +++
>  6 files changed, 44 insertions(+), 5 deletions(-)
>  create mode 100644 tools/build/feature/test-xed.c
> 
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index e3fb5ecbdcb6..971a9ef87ca6 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC :=                  \
>          lzma                            \
>          get_cpuid                       \
>          bpf                             \
> -        sdt
> +	sdt				\

looks like you forgot to add xed in here? why the '\' ?

anyway, please add it in here so it's visible under make VF=1

jirka