linux-kernel - Re: [PATCH 1/2] capability: export has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170111134701.7d153d34@t450s.home>
Date:   Wed, 11 Jan 2017 13:47:01 -0500
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Jike Song <jike.song@...el.com>
Cc:     serge@...lyn.com, linux-security-module@...r.kernel.org,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kwankhede@...dia.com, kraxel@...hat.com
Subject: Re: [PATCH 1/2] capability: export has_capability

On Thu, 22 Dec 2016 00:10:15 +0800
Jike Song <jike.song@...el.com> wrote:

> has_capability() is sometimes needed by modules to test capability
> for specified task other than current, so export it.
> 
> Cc: Alex Williamson <alex.williamson@...hat.com>
> Cc: Kirti Wankhede <kwankhede@...dia.com>
> Signed-off-by: Jike Song <jike.song@...el.com>
> ---
>  kernel/capability.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 4984e1f..e2e198c 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -318,6 +318,7 @@ bool has_capability(struct task_struct *t, int cap)
>  {
>  	return has_ns_capability(t, &init_user_ns, cap);
>  }
> +EXPORT_SYMBOL(has_capability);
>  
>  /**
>   * has_ns_capability_noaudit - Does a task have a capability (unaudited)

Are we using EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL here to match the other
exports in this file?  We could use _GPL to match the expected caller
of this.


Serge,

Do you have any comments on this patch?  I'd be happy to pull it
through the vfio tree with an appropriate Ack.  Thanks,

Alex