linux-kernel - Re: [PATCH] usb: dwc3-exynos remove suspend clock unspecified debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74dfb6fb-6ab0-135b-5d0a-60b69f35ff5a@osg.samsung.com>
Date:   Tue, 10 Jan 2017 21:18:20 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Shuah Khan <shuahkh@....samsung.com>, balbi@...nel.org,
        gregkh@...uxfoundation.org, kgene@...nel.org, krzk@...nel.org
Cc:     linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3-exynos remove suspend clock unspecified debug
 message

Hello Shuah,

On 01/10/2017 06:20 PM, Shuah Khan wrote:
> dwc3-exynos prints debug message when suspend clock is not specified.
> The suspend clock is optional and driver can work without it.
> 
> This debug message doesn't add any value and leads to confusion and
> concern. Remove it.
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
> This patch is a result of the disussion on the following patch.
> https://lkml.org/lkml/2017/1/9/891
> 
> drivers/usb/dwc3/dwc3-exynos.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index e27899b..3e8407a 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -128,10 +128,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
>  	clk_prepare_enable(exynos->clk);
>  
>  	exynos->susp_clk = devm_clk_get(dev, "usbdrd30_susp_clk");
> -	if (IS_ERR(exynos->susp_clk)) {
> -		dev_info(dev, "no suspend clk specified\n");

Sorry for being late in the discussion, but what about making it a
dev_dbg() instead? That way the message may not confuse others but
still keep information that could be useful for debugging purposes.

I know the current message isn't great but keeping it as debug allows
to improve it later.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America