linux-kernel - Re: Support Intel uncore event lists v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2017 13:54:07 -0800
From:   Andi Kleen <andi@...stfloor.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        jolsa@...nel.org, mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: Support Intel uncore event lists v4

On Wed, Jan 11, 2017 at 10:47:32PM +0100, Jiri Olsa wrote:
> On Wed, Jan 11, 2017 at 11:52:58AM -0800, Andi Kleen wrote:
> > > > v1: Initial post
> > > > v2: Address review feedback. See changelog in commits.
> > > > v3: Repost. Rebase to latest tree.
> > > > v4: Rebase. Change DividedBy to generic simple expression parser.
> > > > Fix refactoring problem that broke git bisect.
> > > > Address review feedback.
> > > >
> > > 
> > > what's the difference to the post from Jan 03?
> > 
> > Jan 03 was v3 I think? 
> > 
> > Also I addressed all your review comments (listed in the individual
> > patches)
> 
> 6012     Jan 03 Andi Kleen      (1.5K) Support Intel uncore event lists v4
> 6421 r   Jan 09 Andi Kleen      (1.5K) Support Intel uncore event lists v4
> 
> the messages seem identical

Hmm I messed up the version number then.  This should be version number
5 then.

It was supposed to fix your review feedback for the earlier series
and add Acked-by.

I listed the (minor) changes in the individual patches.

    perf, tools: Add support for parsing uncore json files
    v3: Remove extra __maybe_unused

    perf, tools: Factor out scale conversion code
    v3: Use ENOMEM, not -1.

Really only trivial changes at this point, so you only need to read
the patches you didn't read and ack before.

Thanks,

-Andi