[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170112093131.GC15314@mwanda>
Date: Thu, 12 Jan 2017 12:32:26 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Bogdan Purcareata <bogdan.purcareata@...il.com>
Cc: labbott@...hat.com, sumit.semwal@...aro.org,
gregkh@...uxfoundation.org, arve@...roid.com,
riandrews@...roid.com, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters
On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote:
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata@...il.com>
All staging patches need a changelog, no matter how trivial.
> ---
> drivers/staging/android/ion/ion-ioctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c
> index 7e7431d..e28fffb 100644
> --- a/drivers/staging/android/ion/ion-ioctl.c
> +++ b/drivers/staging/android/ion/ion-ioctl.c
> @@ -111,7 +111,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> struct ion_handle *handle;
>
> mutex_lock(&client->lock);
> - handle = ion_handle_get_by_id_nolock(client, data.handle.handle);
> + handle = ion_handle_get_by_id_nolock(client,
> + data.handle.handle);
Please run checkpatch.pl over your patches before sending them. :P
regards,
dan carpenter
Powered by blists - more mailing lists