linux-kernel - Re: [PATCH] reset: constify reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1484218444.2376.9.camel@pengutronix.de>
Date:   Thu, 12 Jan 2017 11:54:04 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: constify reset_control_ops structures

Am Montag, den 09.01.2017, 22:23 +0530 schrieb Bhumika Goyal:
> Declare reset_control_ops structures as const as they are only stored
> in the ops field of a reset_controller_dev structure. This field is of
> type const struct reset_control_ops *, so reset_control_ops structures
> having this property can be declared as const.
> Done using Coccinelle:
> 
> @r1 disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct reset_control_ops i@......};
> 
> @ok1@
> identifier r1.i;
> position p;
> struct ti_syscon_reset_data data;
> @@
> data.rcdev.ops=&i@p;
> 
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct reset_control_ops i;
> 
> File size before: drivers/reset/reset-ti-syscon.o
>    text	   data	    bss	    dec	    hex	filename
>    1329	    240	      0	   1569	    621	drivers/reset/reset-ti-syscon.o
> 
> File size after: drivers/reset/reset-ti-syscon.o
>    text	   data	    bss	    dec	    hex	filename
>    1377	    192	      0	   1569	    621	drivers/reset/reset-ti-syscon.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Applied, thank you.

regards
Philipp