linux-kernel - Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2zJzETQh8bQ9YeR0r6HhrpPr6P+gRvE39JuZLM6U1O3A@mail.gmail.com>
Date:   Thu, 12 Jan 2017 17:23:57 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     David Howells <dhowells@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Tina Ruchandani <ruchandani.tina@...il.com>,
        linux-afs@...ts.infradead.org
Subject: Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h

On Thu, Jan 12, 2017 at 5:14 PM, David Howells <dhowells@...hat.com> wrote:
>> >         reply.ia.uuid[3] = htonl((s8) afs_uuid.clock_seq_hi_and_reserved);
>> >         reply.ia.uuid[4] = htonl((s8) afs_uuid.clock_seq_low);
>> >         for (loop = 0; loop < 6; loop++)
>>
>> Shouldn't this be ntohs() instead of ntohl(), like this:
>>
>>        reply.ia.uuid[1] = htonl(ntohl(afs_uuid.time_mid));
>>        reply.ia.uuid[2] = htonl(ntohl(afs_uuid.time_hi_and_version));
>
> I think you forgot to change ntohl() to ntohs() in that - and you're right.
>
> Okay, how about the attached?

Yes, looks good to me.

      Arnd