linux-kernel - Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d68af8a-a609-d7b1-58a9-f1155313b077@6wind.com>
Date:   Thu, 12 Jan 2017 17:32:09 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Jan Engelhardt <jengelh@...i.de>
Cc:     Christoph Hellwig <hch@...radead.org>, arnd@...db.de,
        mmarek@...e.com, linux-kbuild@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        linux-c6x-dev@...ux-c6x.org, linux-cris-kernel@...s.com,
        uclinux-h8-devel@...ts.sourceforge.jp,
        linux-hexagon@...r.kernel.org, linux-ia64@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-metag@...r.kernel.org,
        linux-mips@...ux-mips.org, linux-am33-list@...hat.com,
        nios2-dev@...ts.rocketboards.org, openrisc@...ts.librecores.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
        sparclinux@...r.kernel.org, linux-xtensa@...ux-xtensa.org,
        linux-arch@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        netdev@...r.kernel.org, linux-media@...r.kernel.org,
        linux-mmc@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, linux-nfs@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-rdma@...r.kernel.org,
        fcoe-devel@...n-fcoe.org, alsa-devel@...a-project.org,
        linux-fbdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
        airlied@...ux.ie, davem@...emloft.net
Subject: Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

Le 12/01/2017 à 17:28, Jan Engelhardt a écrit :
> On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote:
> 
>> Le 09/01/2017 à 13:56, Christoph Hellwig a écrit :
>>> On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote:
>>>> Regularly, when a new header is created in include/uapi/, the developer
>>>> forgets to add it in the corresponding Kbuild file. This error is usually
>>>> detected after the release is out.
>>>>
>>>> In fact, all headers under uapi directories should be exported, thus it's
>>>> useless to have an exhaustive list.
>>>>
>>>> After this patch, the following files, which were not exported, are now
>>>> exported (with make headers_install_all):
>>>
>>> ... snip ...
>>>
>>>> linux/genwqe/.install
>>>> linux/genwqe/..install.cmd
>>>> linux/cifs/.install
>>>> linux/cifs/..install.cmd
>>>
>>> I'm pretty sure these should not be exported!
>>>
>> Those files are created in every directory:
>> $ find usr/include/ -name '\.\.install.cmd' | wc -l
>> 71
> 
> That still does not mean they should be exported.
> 
> Anything but headers (and directories as a skeleton structure) is maximally suspicious.
> 
What I was trying to say is that I export those directories like other are.
Removing those files is not related to that series.


Regards,
Nicolas