linux-kernel - Re: [PATCH] livepatch/module: print notice of TAINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170112182735.mygo7figi23fzt2g@treble>
Date:   Thu, 12 Jan 2017 12:27:35 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Joe Lawrence <joe.lawrence@...hat.com>
Cc:     linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
        Jessica Yu <jeyu@...hat.com>,
        Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH] livepatch/module: print notice of TAINT_LIVEPATCH

On Thu, Jan 12, 2017 at 11:57:44AM -0500, Joe Lawrence wrote:
> Add back the "tainting kernel with TAINT_LIVEPATCH" kernel log message
> that commit 2992ef29ae01 ("livepatch/module: make TAINT_LIVEPATCH
> module-specific") dropped.  Now that it's a module-specific taint flag,
> include the module name.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@...hat.com>

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

> ---
>  kernel/module.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 5088784c0cf9..330f64e7e193 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2812,6 +2812,8 @@ static int check_modinfo_livepatch(struct module *mod, struct load_info *info)
>  	if (get_modinfo(info, "livepatch")) {
>  		mod->klp = true;
>  		add_taint_module(mod, TAINT_LIVEPATCH, LOCKDEP_STILL_OK);
> +		pr_notice_once("%s: tainting kernel with TAINT_LIVEPATCH\n",
> +			       mod->name);
>  	}
>  
>  	return 0;
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe live-patching" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Josh