linux-kernel - Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170112192209.qih7zm4x6k3rzt4i@ninjato>
Date:   Thu, 12 Jan 2017 20:22:09 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Vladimir Zapolskiy <vz@...ia.com>
Cc:     Mike Looijmans <mike.looijmans@...ic.nl>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, soren.brinkmann@...inx.com,
        michal.simek@...inx.com
Subject: Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's
 ready


> Because the adapter registration i2c_add_adapter() can fail, information
> about the adapter initialization would be expected only in case of
> successful registration.

Exactly.

> 
> The information sent to the kernel log buffer here is quite trivial,
> probably dev_info() can be just removed, but in any case it should be
> a separate change.

I am not sure I get you here, but to not have false positive success
messages, I'd think that should be all in one patch.

Regards,

   Wolfram