linux-kernel - Re: [PATCH 30/62] watchdog: mena21_wdt: Convert to use device managed functions and other improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGH8bx4UeABB0UNDsR+zTB2cER_Lcnguk_+d6oSKG2N0hYYLhA@mail.gmail.com>
Date:   Fri, 13 Jan 2017 09:08:16 +0100
From:   Johannes Thumshirn <morbidrsa@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-watchdog@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 30/62] watchdog: mena21_wdt: Convert to use device managed
 functions and other improvements

> Am 11.01.2017 12:38 vorm. schrieb "Guenter Roeck" <linux@...ck-us.net>:
>
> Use device managed functions to simplify error handling, reduce
> source code size, improve readability, and reduce the likelyhood of bugs.
> Other improvements as listed below.
>
> The conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts used
> to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
>
> - Replace 'goto l; ... l: return e;' with 'return e;'
> - Drop assignments to otherwise unused variables
> - Drop remove function
> - Drop unnecessary mutex_destroy() on allocated data
> - Use devm_watchdog_register_driver() to register watchdog device
>
> Cc: Johannes Thumshirn <morbidrsa@...il.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---

Looks good,
Acked-by: Johannes Thumshirn <jth@...nel.org>