linux-kernel - VME: devices not removed after commit 050c3d52cc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <54f7a6d6-f04d-b13a-04bf-b7e4405d2619@denx.de>
Date:   Fri, 13 Jan 2017 11:03:09 +0100
From:   Stefano Babic <sbabic@...x.de>
To:     paul.gortmaker@...driver.com
Cc:     linux-kernel@...r.kernel.org, stefano babic <sbabic@...x.de>
Subject: VME: devices not removed after commit 050c3d52cc7

Hi,

I have updated a custom VME device driver (mainly based on vme_user.c)
to 4.9 (previously it was for 3.14-).

I see that VME device drivers cannot be loaded and unloaded due to this
commit:

commit 050c3d52cc7810d9d17b8cd231708609af6876ae
Author: Paul Gortmaker <paul.gortmaker@...driver.com>
Date:   Sun Jul 3 14:05:56 2016 -0400

    vme: make core vme support explicitly non-modular

In fact, this drops the remove function, that scans all devices attached
to the bus and call their remove function.

That means that "remove" entry points in VME device driver (let see in
drivers/staging/vme/devices/vme_user.c) are now dead code and the
required cleanup code is not called at all (devices and class are not
removed). Reloading the same driver cause errors due to the missing
cleanup by unloading.  This does not let build VME device drivers as
module, as it is supposed to be done.

Paul, what do you mind ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@...x.de
=====================================================================