linux-kernel - Re: [PATCH] usb: host: xhci: plat: check hcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb57648a-857f-8bf1-f885-e6c6717e5776@ti.com>
Date:   Fri, 13 Jan 2017 13:02:01 +0200
From:   Roger Quadros <rogerq@...com>
To:     William Wu <william.wu@...k-chips.com>,
        <gregkh@...uxfoundation.org>
CC:     <heiko@...ech.de>, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-rockchip@...ts.infradead.org>,
        <frank.wang@...k-chips.com>, <huangtao@...k-chips.com>,
        <dianders@...gle.com>, <groeck@...gle.com>,
        <stern@...land.harvard.edu>
Subject: Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd

Hi,

On 13/01/17 05:18, William Wu wrote:
> From: William wu <william.wu@...k-chips.com>
> 
> The commit 4ac53087d6d4 ("usb: xhci: plat: Create both
> HCDs before adding them") move add hcd to the end of
> probe, this cause hcc_params uninitiated, because xHCI
> driver sets hcc_params in xhci_gen_setup() called from
> usb_add_hcd().
> 
> This patch checks the Maximum Primary Stream Array Size
> in the hcc_params register after add hcd.
> 
> Signed-off-by: William wu <william.wu@...k-chips.com>
> ---
>  drivers/usb/host/xhci-plat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index ddfab30..52ce697 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -232,9 +232,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  	if (device_property_read_bool(&pdev->dev, "usb3-lpm-capable"))
>  		xhci->quirks |= XHCI_LPM_SUPPORT;
>  
> -	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> -		xhci->shared_hcd->can_do_streams = 1;
> -
>  	hcd->usb_phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0);
>  	if (IS_ERR(hcd->usb_phy)) {
>  		ret = PTR_ERR(hcd->usb_phy);
> @@ -255,6 +252,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto dealloc_usb2_hcd;
>  
> +	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> +		xhci->shared_hcd->can_do_streams = 1;
> +

xhci->hcc_params is initialized after the first usb_add_hcd().
Should this bit come before the usb_add_hcd(xhci->shared_hcd,..)?

You will also need to copy to v4.2+ <stable@...r.kernel.org>. Thanks.

>  	return 0;
>  
>  
> 

cheers,
-roger