linux-kernel - Re: [PATCH] fuse: clear FR_PENDING flag when moving requests out of pending queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpeguzsEFAnTUcaU1mcaKYuYENUowArPFepzNMCLgqCVM-Zg@mail.gmail.com>
Date:   Fri, 13 Jan 2017 12:13:04 +0100
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fuse: clear FR_PENDING flag when moving requests out of
 pending queue

On Thu, Jan 12, 2017 at 9:04 PM, Tahsin Erdogan <tahsin@...gle.com> wrote:
> fuse_abort_conn() moves requests from pending list to a temporary list
> before canceling them. This operation races with request_wait_answer()
> which also tries to remove the request after it gets a fatal signal. It
> checks FR_PENDING flag to determine whether the request is still in the
> pending list.
>
> Make fuse_abort_conn() clear FR_PENDING flag so that request_wait_answer()
> does not remove the request from temporary list.
>
> This bug manifests itself as a panic that looks like this:

Perfect patch; applied and pushed.

Thanks,
Miklos