[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170113132315.GC6864@dell>
Date: Fri, 13 Jan 2017 13:23:15 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc: linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
Olof Johansson <olof@...om.net>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
Stephen Barber <smbarber@...omium.org>
Subject: Re: [PATCH 2/4] mfd: cros_ec: Introduce RTC commands and events
definitions.
On Wed, 11 Jan 2017, Enric Balletbo i Serra wrote:
> From: Stephen Barber <smbarber@...omium.org>
>
> The EC can function as a simple RT, this patch adds the RTC related
> definitions needed by the rtc-cros-ec driver.
>
> Signed-off-by: Stephen Barber <smbarber@...omium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
> include/linux/mfd/cros_ec_commands.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
Acked-by: Lee Jones <lee.jones@...aro.org>
> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
> index 80d401d..73f7a62 100644
> --- a/include/linux/mfd/cros_ec_commands.h
> +++ b/include/linux/mfd/cros_ec_commands.h
> @@ -286,6 +286,9 @@ enum host_event_code {
> /* Hang detect logic detected a hang and warm rebooted the AP */
> EC_HOST_EVENT_HANG_REBOOT = 21,
>
> + /* EC RTC event occurred */
> + EC_HOST_EVENT_RTC = 26,
> +
> /*
> * The high bit of the event mask is not used as a host event code. If
> * it reads back as set, then the entire event mask should be
> @@ -790,6 +793,8 @@ enum ec_feature_code {
> EC_FEATURE_USB_MUX = 23,
> /* Motion Sensor code has an internal software FIFO */
> EC_FEATURE_MOTION_SENSE_FIFO = 24,
> + /* EC has RTC feature that can be controlled by host commands */
> + EC_FEATURE_RTC = 27,
> };
>
> #define EC_FEATURE_MASK_0(event_code) (1UL << (event_code % 32))
> @@ -1682,6 +1687,9 @@ struct ec_response_rtc {
> #define EC_CMD_RTC_SET_VALUE 0x46
> #define EC_CMD_RTC_SET_ALARM 0x47
>
> +/* Pass as param to SET_ALARM to clear the current alarm */
> +#define EC_RTC_ALARM_CLEAR 0
> +
> /*****************************************************************************/
> /* Port80 log access */
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists