linux-kernel - Re: [PATCH] Set elsiocb contexts to NULL after freeing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170113152138.GC3409@linux-x5ow.site>
Date:   Fri, 13 Jan 2017 16:21:38 +0100
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     "Martin K . Petersen" <martin.petersen@...cle.com>
Cc:     Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Dick Kennedy <dick.kennedy@...adcom.com>
Subject: Re: [PATCH] Set elsiocb contexts to NULL after freeing it

[+Cc James S. I'm sorry]

On Tue, Jan 10, 2017 at 12:05:54PM +0100, Johannes Thumshirn wrote:
> Set the elsiocb contexts to NULL after freeing as others depend on it.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
>  drivers/scsi/lpfc/lpfc_els.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 236e4e5..7b6bd8e 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -3590,12 +3590,14 @@ lpfc_els_free_iocb(struct lpfc_hba *phba, struct lpfc_iocbq *elsiocb)
>  		} else {
>  			buf_ptr1 = (struct lpfc_dmabuf *) elsiocb->context2;
>  			lpfc_els_free_data(phba, buf_ptr1);
> +			elsiocb->context2 = NULL;
>  		}
>  	}
>  
>  	if (elsiocb->context3) {
>  		buf_ptr = (struct lpfc_dmabuf *) elsiocb->context3;
>  		lpfc_els_free_bpl(phba, buf_ptr);
> +		elsiocb->context3 = NULL;
>  	}
>  	lpfc_sli_release_iocbq(phba, elsiocb);
>  	return 0;

Dick, James, any comments? I'd really like to get this in soon as it solves
customer issues.

Byte,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850