lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Jan 2017 16:37:41 +0100 From: Vitaly Kuznetsov <vkuznets@...hat.com> To: Olaf Hering <olaf@...fle.de> Cc: Thomas Gleixner <tglx@...utronix.de>, devel@...uxdriverproject.org, linux-kernel@...r.kernel.org, Haiyang Zhang <haiyangz@...rosoft.com>, "K. Y. Srinivasan" <kys@...rosoft.com>, John Stultz <john.stultz@...aro.org>, Alex Ng <alexng@...rosoft.com>, Stephen Hemminger <stephen@...workplumber.org> Subject: Re: [PATCH RFC] hv_utils: implement Hyper-V PTP source Olaf Hering <olaf@...fle.de> writes: > On Fri, Jan 13, Vitaly Kuznetsov wrote: > >> + hv_ptp_clock = ptp_clock_register(&ptp_hyperv_info, NULL); >> + if (IS_ERR(hv_ptp_clock)) { > > Should that be IS_ERR_OR_NULL to catch "!IS_REACHABLE(CONFIG_PTP_1588_CLOCK)"? > Oh, yes. I missed the case when CONFIG_PTP_1588_CLOCK is disabled completely. I'll also remove the return below to not fail the device completely. Even if there is no PTP support in kernel the ICTIMESYNCFLAG_SYNC case which triggers do_settimeofday64() is still probably useful. -- Vitaly
Powered by blists - more mailing lists