linux-kernel - Re: [PATCH v3 1/8] arm: put types.h in uapi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170113161951.GT14217@n2100.armlinux.org.uk>
Date:   Fri, 13 Jan 2017 16:19:52 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     David Howells <dhowells@...hat.com>, arnd@...db.de,
        linux-mips@...ux-mips.org, linux-m68k@...r.kernel.org,
        linux-ia64@...r.kernel.org, linux-doc@...r.kernel.org,
        alsa-devel@...a-project.org, dri-devel@...ts.freedesktop.org,
        linux-mtd@...ts.infradead.org, sparclinux@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-am33-list@...hat.com, linux-c6x-dev@...ux-c6x.org,
        linux-rdma@...r.kernel.org, linux-hexagon@...r.kernel.org,
        linux-sh@...r.kernel.org, coreteam@...filter.org,
        fcoe-devel@...n-fcoe.org, xen-devel@...ts.xenproject.org,
        linux-snps-arc@...ts.infradead.org, linux-media@...r.kernel.org,
        uclinux-h8-devel@...ts.sourceforge.jp,
        linux-xtensa@...ux-xtensa.org, linux-kbuild@...r.kernel.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        linux-raid@...r.kernel.org, openrisc@...ts.librecores.org,
        linux-fbdev@...r.kernel.org, linux-metag@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-nfs@...r.kernel.org,
        linux-parisc@...r.kernel.org, linux-cris-kernel@...s.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, netfilter-devel@...r.kernel.org,
        linux-alpha@...r.kernel.org, nio2-dev@...ts.rocketboards.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v3 1/8] arm: put types.h in uapi

On Fri, Jan 13, 2017 at 05:01:01PM +0100, Nicolas Dichtel wrote:
> Please, do not remove the email subject when you reply. I restore it to
> ease the thread follow-up.

I mentioned it to David, and he says it's because the long list of
recipients is breaking his mailer.  I've already posed the question
about whether that's exploitable!

> Le 13/01/2017 à 16:36, David Howells a écrit :
> > Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:
> > 
> >> This header file is exported, thus move it to uapi.
> > 
> > Exported how?
> 
> It is listed in include/uapi/asm-generic/Kbuild.asm, which is included by
> arch/arm/include/uapi/asm/Kbuild.

We really should not be installing non-uapi header files to userland
under _any_ circumstance - this to me sounds like a bug in kbuild.

The assumption is that headers outside of uapi directories are not
part of the user visible API, and so can be freely modified - which
in the presence of this bug is untrue.

However, as it's happening, and this header has been there since 2013
(commit 09096f6a0ee2 - "ARM: 7822/1: add workaround for ambiguous C99
stdint.h types") it's now well and truely part of the user API whether
we intended it to be or not, so your patch looks to me like the correct
thing to do.

I think it needs further evaluation to make sure kbuild isn't going to
do something else silly, like subsitute include/asm-generic/types.h for
the now missing arch/arm/include/asm/types.h

I wonder how many more headers are unintentionally exported.

... what a mess. :(

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.