linux-kernel - Re: [PATCH v3 4/8] x86: stop exporting msr-index.h to userland

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Jan 2017 17:38:36 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     David Howells <dhowells@...hat.com>, arnd@...db.de,
        linux-kbuild@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
        linux-snps-arc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        linux-c6x-dev@...ux-c6x.org, linux-cris-kernel@...s.com,
        uclinux-h8-devel@...ts.sourceforge.jp,
        linux-hexagon@...r.kernel.org, linux-ia64@...r.kernel.org,
        linux-m68k@...r.kernel.org, linux-metag@...r.kernel.org,
        linux-mips@...ux-mips.org, linux-am33-list@...hat.com,
        nios2-dev@...ts.rocketboards.org, openrisc@...ts.librecores.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
        sparclinux@...r.kernel.org, linux-xtensa@...ux-xtensa.org,
        linux-arch@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        netdev@...r.kernel.org, linux-media@...r.kernel.org,
        linux-mmc@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, linux-nfs@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-rdma@...r.kernel.org,
        fcoe-devel@...n-fcoe.org, alsa-devel@...a-project.org,
        linux-fbdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
        linux@...linux.org.uk
Subject: Re: [PATCH v3 4/8] x86: stop exporting msr-index.h to userland

On Fri, Jan 13, 2017 at 05:08:34PM +0100, Nicolas Dichtel wrote:
> Le 13/01/2017 à 16:43, David Howells a écrit :
> >> -header-y += msr-index.h
> > 
> > I see it on my desktop as /usr/include/asm/msr-index.h and it's been there at
> > least four years - and as such it's part of the UAPI.  I don't think you can
> > remove it unless you can guarantee there are no userspace users.
> I keep it in the v2 of the series, but the maintainer, Borislav Petkov, asks me
> to un-export it.
> 
> I will follow the maintainer decision.

I'm not the maintainer. I simply think that exporting that file was
wrong because it if we change something in it, we will break userspace.
And that should not happen - if userspace needs MSRs, it should do its
own defines.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.