linux-kernel - Re: [PATCH] soc: dove: constify reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737gm99xd.fsf@free-electrons.com>
Date:   Fri, 13 Jan 2017 17:55:26 +0100
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
Cc:     Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: dove: constify reset_control_ops structures

Hi Russell King,
 
 On ven., janv. 13 2017, Russell King - ARM Linux <linux@...linux.org.uk> wrote:

> On Fri, Jan 13, 2017 at 05:36:42PM +0100, Gregory CLEMENT wrote:
>> Hi Sebastian,
>>  
>>  On lun., janv. 09 2017, Bhumika Goyal <bhumirks@...il.com> wrote:
>> 
>> > Declare reset_control_ops as const as they are only stored in the ops
>> > field of a reset_controller_dev structure. This field is of type const
>> > struct reset_control_ops *, so reset_control_ops structures having this
>> > property can be declared as const.
>> > Done using Coccinelle:
>> >
>> > @r1 disable optional_qualifier@
>> > identifier i;
>> > position p;
>> > @@
>> > static struct reset_control_ops i@......};
>> >
>> > @ok1@
>> > identifier r1.i;
>> > position p;
>> > struct reset_controller_dev x;
>> > @@
>> > x.ops=&i@p;
>> >
>> > @bad@
>> > position p!={r1.p,ok1.p};
>> > identifier r1.i;
>> > @@
>> > i@p
>> >
>> > @depends on !bad disable optional_qualifier@
>> > identifier r1.i;
>> > @@
>> > +const
>> > struct reset_control_ops i;
>> >
>> > File size before: drivers/soc/dove/pmu.o
>> >    text	   data	    bss	    dec	    hex	filename
>> >    2447	    112	     16	   2575	    a0f	drivers/soc/dove/pmu.o
>> >
>> > File size after: drivers/soc/dove/pmu.o
>> >    text	   data	    bss	    dec	    hex	filename
>> >    2479	     80	     16	   2575	    a0f	drivers/soc/dove/pmu.o
>> >
>> 
>> If you agree with this patch I will apply it on mvebu/soc.
>
> You really ought to be asking me...

Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he
would have redirect me to you :)

>
> Acked-by: Russell King <rmk+kernel@...linux.org.uk>


Applied on mvebu/soc

Thanks,

Gregory


>
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com