linux-kernel - [PATCH] tools/vm: Add missing Makefile rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Jan 2017 16:56:30 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Daniel Thompson <daniel.thompson@...aro.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, patches@...aro.org
Subject: [PATCH] tools/vm: Add missing Makefile rules

Currently the tools/vm Makefile has a rather arbitrary implicit build
rule; page-types is the first value in TARGETS so lets just build that
one! Additionally there is no install rule and this is needed for
make -C tools vm_install to work properly.

Provide a more sensible implicit build rule and a new install rule.

Note that the variables names used by the install rule (DESTDIR and
sbindir) are copied from prior-art in tools/power/cpupower.

Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
---

Notes:
    This is a resend with the linux-mm list spelled correctly (and with
    special apologies to Andrew for the spam).

 tools/vm/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/vm/Makefile b/tools/vm/Makefile
index 93aadaf7ff63..006029456988 100644
--- a/tools/vm/Makefile
+++ b/tools/vm/Makefile
@@ -9,6 +9,8 @@ CC = $(CROSS_COMPILE)gcc
 CFLAGS = -Wall -Wextra -I../lib/
 LDFLAGS = $(LIBS)

+all: $(TARGETS)
+
 $(TARGETS): $(LIBS)

 $(LIBS):
@@ -20,3 +22,9 @@ $(LIBS):
 clean:
 	$(RM) page-types slabinfo page_owner_sort
 	make -C $(LIB_DIR) clean
+
+sbindir ?= /usr/sbin
+
+install: all
+	install -d $(DESTDIR)$(sbindir)
+	install -m 755 -p $(TARGETS) $(DESTDIR)$(sbindir)
--
2.9.3