linux-kernel - Re: [PATCH] perf script: Also allow forcing reading of non-root owned files by root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170113192440.GC32549@kernel.org>
Date:   Fri, 13 Jan 2017 16:24:40 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Yannick Brosseau <scientist@...com>
Cc:     namhyung@...nel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, mbd@...com
Subject: Re: [PATCH] perf script: Also allow forcing reading of non-root
 owned files by root

Em Fri, Jan 13, 2017 at 01:25:27PM -0500, Yannick Brosseau escreveu:
> In 2059fc7a5a9e6677, perf report was added the option of forcing reading
> of non-root owned symbol file.
> 
> This add the same behavior for perf script.

looks ok, applied.

- Arnaldo
 
> Reported-by: Mark Drayton <mbd@...com>
> Signed-off-by: Yannick Brosseau <scientist@...com>
> ---
>  tools/perf/builtin-script.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 2f3ff69fc4e7..c0783b4f7b6c 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2180,7 +2180,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
>  		    "Show the mmap events"),
>  	OPT_BOOLEAN('\0', "show-switch-events", &script.show_switch_events,
>  		    "Show context switch events (if recorded)"),
> -	OPT_BOOLEAN('f', "force", &file.force, "don't complain, do it"),
> +	OPT_BOOLEAN('f', "force", &symbol_conf.force, "don't complain, do it"),
>  	OPT_BOOLEAN(0, "ns", &nanosecs,
>  		    "Use 9 decimal places when displaying time"),
>  	OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",
> @@ -2212,6 +2212,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
>  			     PARSE_OPT_STOP_AT_NON_OPTION);
>  
>  	file.path = input_name;
> +	file.force = symbol_conf.force;
>  
>  	if (argc > 1 && !strncmp(argv[0], "rec", strlen("rec"))) {
>  		rec_script_path = get_script_path(argv[1], RECORD_SUFFIX);
> -- 
> 2.11.0