linux-kernel - Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484337634.1720.4.camel@gmx.de>
Date:   Fri, 13 Jan 2017 21:00:34 +0100
From:   Manuel Schölling <manuel.schoelling@....de>
To:     Adam Borowski <kilobyte@...band.pl>
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com, lkml14@...tdoyle.com,
        rdunlap@...radead.org, shorne@...il.com, andrey_utkin@...tmail.com,
        akpm@...ux-foundation.org, paul.burton@...tec.com,
        daniel.vetter@...ll.ch, tj@...nel.org, hdegoede@...hat.com,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot
 parameter

On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote:
> On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote:
> > The impact of the persistent scrollback feature on the code size is
> > rather small, so the config option is removed. The feature stays
> > disabled by default and can be enabled by using the boot command
> > line
> > parameter 'vgacon.scrollback_persistent=1' or by setting
> > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y.
> > 
> > Signed-off-by: Manuel Schölling <manuel.schoelling@....de>
> > Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> > +module_param_named(scrollback_persistent, scrollback_persistent,
> > bool, 0000);
> > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent
> > scrollback for all vga consoles");
> 
> A command-line knob settable by the end-user is something more
> persistent
> than a config option.  As you're going to extend this code beyond
> vgacon in
> the near future, perhaps it'd be better to have a shared setting for
> all
> console drivers?
According to the guys at #kernelnewbies on IRC everybody hates new
command line options.
I'd rather stick to the module parameter for now and maybe introduce a 
new cmd line option later, once this feature has been implemented in
several console drivers.

Bye,

Manuel