linux-kernel - Re: [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdbd3d91-9b01-20a2-50a7-1ae6a0d71a47@amd.com>
Date:   Sat, 14 Jan 2017 17:13:33 +0700
From:   Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     <linux-kernel@...r.kernel.org>, <iommu@...ts.linux-foundation.org>,
        <joro@...tes.org>, <peterz@...radead.org>, <mingo@...hat.com>
Subject: Re: [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove
 unnecessary pr_debug



On 1/12/17 17:19, Borislav Petkov wrote:
> Also, looking at that driver more, this needs to die, like now:
>
> #define format_group    attr_groups[0]
> #define cpumask_group   attr_groups[1]
> #define events_group    attr_groups[2]
> #define null_group      attr_groups[3]
>
> Like, kill it dead. Define a separate array, look what the other drivers
> do, whatever, but this is too ugly to live.
>
> Thanks.
>
> --

Okay... you got it :)

S