linux-kernel - Re: [PATCH] cxgb4: Remove redundant memset before memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170114122739.GG1201@distanz.ch>
Date:   Sat, 14 Jan 2017 13:27:40 +0100
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Shyam Saini <mayhs11saini@...il.com>
Cc:     hariprasad@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxgb4:  Remove redundant memset before memcpy

On 2017-01-14 at 02:17:40 +0100, Shyam Saini <mayhs11saini@...il.com> wrote:
> The region set by the call to memset, immediately overwritten by
> the subsequent call to memcpy and thus makes the  memset redundant.
> 
> Also remove the memset((&info, 0, sizeof(info)) on line 398 because
> info is memcpy()'ed to before being used in the loop and it isn't
> used outside of the loop.
> 
> Signed-off-by: Shyam Saini <mayhs11saini@...il.com>

Reviewed-by: Tobias Klauser <tklauser@...tanz.ch>