lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Jan 2017 13:10:43 +0000 From: Jonathan Cameron <jic23@...nel.org> To: Linus Walleij <linus.walleij@...aro.org>, Colin King <colin.king@...onical.com> Cc: Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] iio: magnetometer: ak8974: remove redundant zero timeout check On 11/01/17 23:11, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 6:49 PM, Colin King <colin.king@...onical.com> wrote: > >> From: Colin Ian King <colin.king@...onical.com> >> >> At the end of the delay loop timeout will always be zero >> and hence the check for !timeout will always be true. Remove >> the redundant check and the redundant return 0 at the end of >> the function. >> >> Fixes CoverityScan CID#1357168 ("Logically dead code") >> >> Signed-off-by: Colin Ian King <colin.king@...onical.com> > > Clever Coverity scan. > Reviewed-by: Linus Walleij <linus.walleij@...aro.org> > Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Powered by blists - more mailing lists