linux-kernel - Re: [PATCH] radix-tree: Fix private list warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 14 Jan 2017 10:42:31 -0500
From:   Johannes Weiner <hannes@...xchg.org>
To:     Matthew Wilcox <mawilcox@...uxonhyperv.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] radix-tree: Fix private list warnings

On Thu, Jan 12, 2017 at 05:28:23PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@...rosoft.com>
> 
> The newly introduced warning in radix_tree_free_nodes() was testing the
> wrong variable; it should have been 'old' instead of 'node'.  Rather
> than replace that one instance, I noticed that we can simply put the
> WARN_ON_ONCE in radix_tree_node_free() and it will be just as effective.
> 
> Fixes: ea07b862ac8e ("mm: workingset: fix use-after-free in shadow node shrinker")
> Signed-off-by: Matthew Wilcox <mawilcox@...rosoft.com>

Thanks for the fix in radix_tree_free_nodes(). But I intentionally
spread out the warnings to retain the line numbers. The inlining in
that code will obscure which tree operation ends up triggering.