linux-kernel - Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e17acc8c-01b9-284c-a321-5135de80c2b7@lechnology.com>
Date:   Sat, 14 Jan 2017 12:09:33 -0600
From:   David Lechner <david@...hnology.com>
To:     Jonathan Cameron <jic23@...nel.org>, devicetree@...r.kernel.org,
        linux-iio@...r.kernel.org
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching
 string to "vref"

On 01/14/2017 06:52 AM, Jonathan Cameron wrote:
> On 11/01/17 17:52, David Lechner wrote:
>> This changes the reference voltage regulator matching string from "refin"
>> to "vref". This is to be consistent with other A/DC chips that also use
>> "vref-supply" in their device tree bindings.
>>
>> Signed-off-by: David Lechner <david@...hnology.com>
>> ---
>>  drivers/iio/adc/ti-ads7950.c | 6 +++---
> Again, we missed this before and it would have been nice to have
> had it as vref (which is matches the datasheet).  The question
> becomes how do we handle this going forward with no risk of breaking
> existing device trees.  We may have to do an optional get on one
> name and then a non optional on the second. It's ugly, but
> would fix this up in a 'safe' way.
>

Again, I don't think it is too late since this driver only exists in the 
iio/testing branch.

> Jonathan
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
>> index b587fa6..16a0663 100644
>> --- a/drivers/iio/adc/ti-ads7950.c
>> +++ b/drivers/iio/adc/ti-ads7950.c
>> @@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi)
>>  	spi_message_init_with_transfers(&st->scan_single_msg,
>>  					st->scan_single_xfer, 3);
>>
>> -	st->reg = devm_regulator_get(&spi->dev, "refin");
>> +	st->reg = devm_regulator_get(&spi->dev, "vref");
>>  	if (IS_ERR(st->reg)) {
>> -		dev_err(&spi->dev, "Failed get get regulator \"refin\"\n");
>> +		dev_err(&spi->dev, "Failed get get regulator \"vref\"\n");
>>  		return PTR_ERR(st->reg);
>>  	}
>>
>>  	ret = regulator_enable(st->reg);
>>  	if (ret) {
>> -		dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n");
>> +		dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n");
>>  		return ret;
>>  	}
>>
>>
>