linux-kernel - Re: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 14 Jan 2017 19:39:00 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kartikey Singh <dr.kartikeynrc@...il.com>
Cc:     insafonov@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon
 after macro definition

On Sat, Jan 14, 2017 at 11:47:56PM +0530, Kartikey Singh wrote:
> fixed a trailing semicolon after macro definition
> 
> Signed-off-by: Kartikey Singh <dr.kartikeynrc@...il.com>
> ---
>  drivers/staging/rtl8188eu/include/basic_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/drivers/staging/rtl8188eu/include/basic_types.h
> index 69c4d49..cbd6f92 100644
> --- a/drivers/staging/rtl8188eu/include/basic_types.h
> +++ b/drivers/staging/rtl8188eu/include/basic_types.h
> @@ -128,7 +128,7 @@ value to host byte ordering.*/
>  		(						\
>  		LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \
>  		((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \
> -		);
> +		)

This macro, and others in this file, are also never used, can you just
remove them too?

thanks,

greg k-h