linux-kernel - Re: [PATCH] char: ipmi: constify ipmi_smi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 Jan 2017 14:28:12 -0600
From:   Corey Minyard <minyard@....org>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        openipmi-developer@...ts.sourceforge.net,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: ipmi: constify ipmi_smi_handlers structures

On 01/15/2017 01:15 PM, Bhumika Goyal wrote:
> Declare ipmi_smi_handlers structures as const as they are only passed as
> an argument to the function ipmi_register_smi. This argument is of type
> const, so ipmi_smi_handlers structures having similar properties can be
> declared const too.
> Done using Coccinelle:

Thanks, queues for the next Linux patch mayhem.

-corey

> @r1 disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct ipmi_smi_handlers i@......};
>
> @ok1@
> identifier r1.i;
> position p;
> @@
> ipmi_register_smi(&i@p,...)
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct ipmi_smi_handlers i;
>
> Size details after cross compiling the .o file for powerpc architecture
>
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    2777	    288	      0	   3065	    bf9	drivers/char/ipmi/ipmi_powernv.o
>
> File size after:
>    text	   data	    bss	    dec	    hex	filename
>     2873	    192	      0	   3065	    bf9	drivers/char/ipmi/ipmi_powernv.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>   drivers/char/ipmi/ipmi_powernv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
> index 6e658aa..b338a4b 100644
> --- a/drivers/char/ipmi/ipmi_powernv.c
> +++ b/drivers/char/ipmi/ipmi_powernv.c
> @@ -196,7 +196,7 @@ static void ipmi_powernv_poll(void *send_info)
>   	ipmi_powernv_recv(smi);
>   }
>   
> -static struct ipmi_smi_handlers ipmi_powernv_smi_handlers = {
> +static const struct ipmi_smi_handlers ipmi_powernv_smi_handlers = {
>   	.owner			= THIS_MODULE,
>   	.start_processing	= ipmi_powernv_start_processing,
>   	.sender			= ipmi_powernv_send,