linux-kernel - Calling device_init_wakeup() on driver removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4f92201-77f6-4a15-81cf-8f2f384d0c1f@roeck-us.net>
Date:   Sat, 14 Jan 2017 20:46:05 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Calling device_init_wakeup() on driver removal

Hi folks,

while looking through driver initialization and removal functions, I noticed that many drivers
call device_init_wakeup(dev, false) in the removal function. Given that the driver is about
to be removed, that doesn't make much sense to me, especially since device_wakeup_disable()
is called from device_pm_remove() anyway.

Is it safe to assume that all those calls can be removed, or is there a possible reason for
keeping them around ?

Thanks,
Guenter