linux-kernel - Re: [PATCHSET v6] blk-mq scheduling framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <C14FF2E2-886B-4EFD-8FBB-7DC528B02373@linaro.org>
Date:   Sun, 15 Jan 2017 11:12:01 +0100
From:   Paolo Valente <paolo.valente@...aro.org>
To:     Jens Axboe <axboe@...com>
Cc:     Linux-Kernal <linux-kernel@...r.kernel.org>,
        linux-block@...r.kernel.org, Omar Sandoval <osandov@...ndov.com>,
        bart.vanassche@...disk.com
Subject: Re: [PATCHSET v6] blk-mq scheduling framework


> Il giorno 11 gen 2017, alle ore 22:39, Jens Axboe <axboe@...com> ha scritto:
> 
> Another year, another posting of this patchset. The previous posting
> was here:
> 
> https://www.spinics.net/lists/kernel/msg2406106.html
> 
> (yes, I've skipped v5, it was fixes on top of v4, not the rework).
> 
> I've reworked bits of this to get rid of the shadow requests, thanks
> to Bart for the inspiration. The missing piece, for me, was the fact
> that we have the tags->rqs[] indirection array already. I've done this
> somewhat differently, though, by having the internal scheduler tag
> map be allocated/torn down when an IO scheduler is attached or
> detached. This also means that when we run without a scheduler, we
> don't have to do double tag allocations, it'll work like before.
> 
> The patchset applies on top of 4.10-rc3, or can be pulled here:
> 
> git://git.kernel.dk/linux-block blk-mq-sched.6
> 
> 

Hi Jens,
I have checked this new version to find solutions to the apparent
errors, mistakes or just unclear parts (to me) that I have pointed out
before Christmas last year.  But I have found no changes related to
these problems.

As I have already written, I'm willing to try to fix those errors
myself, if they really are errors, but I would first need at least
some minimal initial feedback and guidance.  If needed, tell me how I
can help you get in sync again with these issues (sending my reports
again, sending a digest of them, ...).

Thanks,
Paolo

> block/Kconfig.iosched    |   50 ++++
> block/Makefile           |    3 
> block/blk-core.c         |   19 -
> block/blk-exec.c         |    3 
> block/blk-flush.c        |   15 -
> block/blk-ioc.c          |   12 
> block/blk-merge.c        |    4 
> block/blk-mq-sched.c     |  354 +++++++++++++++++++++++++++++
> block/blk-mq-sched.h     |  157 ++++++++++++
> block/blk-mq-sysfs.c     |   13 +
> block/blk-mq-tag.c       |   58 ++--
> block/blk-mq-tag.h       |    4 
> block/blk-mq.c           |  413 +++++++++++++++++++---------------
> block/blk-mq.h           |   40 +++
> block/blk-tag.c          |    1 
> block/blk.h              |   26 +-
> block/cfq-iosched.c      |    2 
> block/deadline-iosched.c |    2 
> block/elevator.c         |  247 +++++++++++++++-----
> block/mq-deadline.c      |  569 +++++++++++++++++++++++++++++++++++++++++++++++
> block/noop-iosched.c     |    2 
> drivers/nvme/host/pci.c  |    1 
> include/linux/blk-mq.h   |    9 
> include/linux/blkdev.h   |    6 
> include/linux/elevator.h |   36 ++
> 25 files changed, 1732 insertions(+), 314 deletions(-)
> 
> -- 
> Jens Axboe
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html