linux-kernel - Bluetooth: always-true condition in dtl1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 15 Jan 2017 12:04:41 +0100
From:   Nicolas Iooss <nicolas.iooss_linux@....org>
To:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Gustavo Padovan <gustavo@...ovan.org>,
        linux-bluetooth@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Bluetooth: always-true condition in dtl1_confcheck

Hello,

Since commit 00990e7ce0b0 ("pcmcia: use autoconfiguration feature for
ioports and iomem") function dtl1_confcheck() starts with the following
statements (in drivers/bluetooth/dtl1_cs.c):

    static int dtl1_confcheck(struct pcmcia_device *p_dev, void *priv_data)
    {
        if ((p_dev->resource[1]->end) || (p_dev->resource[1]->end < 8))
            return -ENODEV;

The condition in the if statement is always true and the compiler
reports an issue when building with -Wlogical-op. What was the condition
supposed to be?

Thanks,
Nicolas