lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jan 2017 18:08:26 +0800 From: Chris Zhong <zyw@...k-chips.com> To: dianders@...omium.org, tfiga@...omium.org, heiko@...ech.de, yzq@...k-chips.com, mark.rutland@....com, devicetree@...r.kernel.org, robh+dt@...nel.org, galak@...eaurora.org, pawel.moll@....com, seanpaul@...omium.org Cc: linux-rockchip@...ts.infradead.org, Mark Yao <mark.yao@...k-chips.com>, Chris Zhong <zyw@...k-chips.com>, David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: [PATCH v2 06/11] drm/rockchip/dsi: return probe defer if attach panel failed From: Mark Yao <mark.yao@...k-chips.com> Return -EINVAL would cause mipi dsi bad behavior, probe defer to ensure mipi find the correct mode, Signed-off-by: Mark Yao <mark.yao@...k-chips.com> Signed-off-by: Chris Zhong <zyw@...k-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index d2a3efb..5e3f031 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c @@ -549,10 +549,14 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host, dsi->channel = device->channel; dsi->format = device->format; dsi->panel = of_drm_find_panel(device->dev.of_node); - if (dsi->panel) - return drm_panel_attach(dsi->panel, &dsi->connector); + if (!dsi->panel) { + DRM_ERROR("failed to find panel\n"); + return -EPROBE_DEFER; + } - return -EINVAL; + drm_panel_attach(dsi->panel, &dsi->connector); + + return 0; } static int dw_mipi_dsi_host_detach(struct mipi_dsi_host *host, @@ -560,7 +564,8 @@ static int dw_mipi_dsi_host_detach(struct mipi_dsi_host *host, { struct dw_mipi_dsi *dsi = host_to_dsi(host); - drm_panel_detach(dsi->panel); + if (dsi->panel) + drm_panel_detach(dsi->panel); return 0; } -- 2.6.3
Powered by blists - more mailing lists