linux-kernel - Re: [RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <111ae8a1-c626-9285-5704-0af45f4b510d@codeaurora.org>
Date:   Mon, 16 Jan 2017 07:45:48 +0530
From:   Ritesh Harjani <riteshh@...eaurora.org>
To:     Jeremy McNicoll <jmcnicol@...hat.com>
Cc:     ulf.hansson@...aro.org, adrian.hunter@...el.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        shawn.lin@...k-chips.com, stummala@...eaurora.org,
        georgi.djakov@...aro.org, linux-arm-msm@...r.kernel.org,
        pramod.gurav@...aro.org, jeremymc@...hat.com,
        venkatg@...eaurora.org, asutoshd@...eaurora.org,
        subhashj@...eaurora.org
Subject: Re: [RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback
 support to sdhci_ops.

Hi Jeremy,

Thanks for the review.

On 1/14/2017 3:51 AM, Jeremy McNicoll wrote:
> On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote:
>> From: Sahitya Tummala <stummala@...eaurora.org>
>>
>> Add new host operation ->platform_dumpregs to provide a
>> mechanism through which host drivers can dump platform
>> specific registers in addition to SDHC registers
>> during error conditions.
>>
>> Signed-off-by: Sahitya Tummala <stummala@...eaurora.org>
>> Signed-off-by: Ritesh Harjani <riteshh@...eaurora.org>
>> ---
>>  drivers/mmc/host/sdhci.c | 3 +++
>>  drivers/mmc/host/sdhci.h | 1 +
>>  2 files changed, 4 insertions(+)
>>
>
> This change and 2/3 look like they can be squished together into
> one patch.  At least that is how I did it,

I felt it is better this way to keep sdhci and sdhci-msm patches 
separate. This patch provides mechanism and patch 3/3 provides
implementation of ->platform_dumpregs in sdhci-msm.

Regards
Ritesh


>
> https://patchwork.kernel.org/patch/9442449/
>
> -jeremy
>
>
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index 2390980..73a8918 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -101,6 +101,9 @@ static void sdhci_dumpregs(struct sdhci_host *host)
>>  			       readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
>>  	}
>>
>> +	if (host->ops->platform_dumpregs)
>> +		host->ops->platform_dumpregs(host);
>> +
>>  	pr_err(DRIVER_NAME ": ===========================================\n");
>>  }
>>
>> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
>> index 0b66f21..400f3a1 100644
>> --- a/drivers/mmc/host/sdhci.h
>> +++ b/drivers/mmc/host/sdhci.h
>> @@ -564,6 +564,7 @@ struct sdhci_ops {
>>  					 struct mmc_card *card,
>>  					 unsigned int max_dtr, int host_drv,
>>  					 int card_drv, int *drv_type);
>> +	void	(*platform_dumpregs)(struct sdhci_host *host);
>>  };
>>
>>  #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
>> --
>> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>> a Linux Foundation Collaborative Project.
>>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project