linux-kernel - Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <783013e0-1da8-3af8-a819-646eb25b9030@osg.samsung.com>
Date:   Mon, 16 Jan 2017 09:30:14 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>, linux-kernel@...r.kernel.org
Cc:     Laxman Dewangan <ldewangan@...dia.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

Hello Chanwoo,

Thanks for the review.

On 01/16/2017 03:46 AM, Chanwoo Choi wrote:
> Hi,
> 
> I think that this patch better to squash with patch3.
> After applying the patch3, this driver doesn't use
> the max77686_i2c_id table.
> 

I usually prefer to separate each change in a different patch,
AFAICT moving to use the .probe_new callback and removing the
I2C id table are two different changes.

I can squash if that's the correct approach though, I will let
Lee decide.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America