linux-kernel - Re: [PATCH v5] tpm: Check size of response before accessing data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170116132512.zyzt4gflticb6xz2@intel.com>
Date:   Mon, 16 Jan 2017 15:25:12 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:     tpmdd-devel@...ts.sourceforge.net,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] tpm: Check size of response before accessing data

On Mon, Jan 16, 2017 at 03:24:09PM +0200, Jarkko Sakkinen wrote:
> On Fri, Jan 13, 2017 at 09:36:34PM -0500, Stefan Berger wrote:
> > Make sure that we have not received less bytes than what is indicated
> > in the header of the TPM response. Also, check the number of bytes in
> > the response before accessing its data.
> > 
> > Signed-off-by: Stefan Berger <stefanb@...ux.vnet.ibm.com>
> 
> There are some things that I want to comment after all but I can give
> now
> 
> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> 
> I also noticed that this patch is not CC'd to linux-kernel.

Please go through the whole patch and remove arithmetic
from every possible place where you only end up with a
constant.

/Jarkko