linux-kernel - Re: [PATCH] ALSA: mips: avoid potential uninitialized variable use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a21FY+4S1zONxnE28eVDmmHTcyR5ymiFJ2Y7X-CxZBAMA@mail.gmail.com>
Date:   Mon, 16 Jan 2017 14:26:31 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        linux-mips@...ux-mips.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: mips: avoid potential uninitialized variable use

On Mon, Jan 16, 2017 at 1:28 PM, Takashi Iwai <tiwai@...e.de> wrote:
> On Mon, 16 Jan 2017 12:04:56 +0100,
> Arnd Bergmann wrote:
>> It's easy enough to avoid by adding a 'default' clause to the switch
>> statements here. I assume that in practice no other case can happen,
>> but adding a default puts us on the safe side and shuts up the warnings.
>
> Well, these cases are logical errors that must not happen, so
> returning an error would be a "safer", IMO.

Agreed. I sent out a v2 now.

    Arnd