linux-kernel - Re: [PATCH] xfrm: state: fix potential null pointer dereference on afinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170116132704.GQ3541@gauss.secunet.com>
Date:   Mon, 16 Jan 2017 14:27:04 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Colin King <colin.king@...onical.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xfrm: state: fix potential null pointer dereference on
 afinfo

On Fri, Jan 13, 2017 at 02:07:03PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> afinfo is being null checked before a call afinfo->init_tempsel
> so afinfo may be potentially null. ifinfo may still be null in
> the case were it is not updated when family == tmpl->encap_family,
> hence we may hit a null pointer dereference in the call to
> afinfo->init_temprop.
> 
> Fix this by adding a null ptr check before calling init_temprop.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

I've applied already a fix for this from Florian Westphal.

Thanks a lot anyway!