linux-kernel - Re: [PATCH v2] virtio_console: fix a crash in config_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170116153032-mutt-send-email-mst@kernel.org>
Date:   Mon, 16 Jan 2017 15:30:42 +0200
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Amit Shah <amit.shah@...hat.com>
Cc:     "G. Campana" <gcampana@...rkslab.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] virtio_console: fix a crash in config_work_handler

On Mon, Jan 16, 2017 at 03:57:23PM +0530, Amit Shah wrote:
> On (Mon) 16 Jan 2017 [10:45:02], G. Campana wrote:
> > Using control_work instead of config_work as the 3rd argument to
> > container_of results in an invalid portdev pointer. Indeed, the work
> > structure is initialized as below:
> > 
> >     INIT_WORK(&portdev->config_work, &config_work_handler);
> > 
> > It leads to a crash when portdev->vdev is dereferenced later. This bug
> > is triggered when the guest uses a virtio-console without multiport
> > feature and receives a config_changed virtio interrupt.
> > 
> > Signed-off-by: G. Campana <gcampana@...rkslab.com>
> 
> Reviewed-by: Amit Shah <amit.shah@...hat.com>
> 
> Michael, can you please pick this up?
> 
> 		Amit

Sure.