linux-kernel - Re: [PATCH v3] ALSA: mips: avoid potential uninitialized variable use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h60lfxh64.wl-tiwai@suse.de>
Date:   Mon, 16 Jan 2017 14:34:11 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] ALSA: mips: avoid potential uninitialized variable use

On Mon, 16 Jan 2017 14:27:57 +0100,
Arnd Bergmann wrote:
> 
> MIPS allmodconfig results in this warning:
> 
> sound/mips/hal2.c: In function 'hal2_gain_get':
> sound/mips/hal2.c:224:35: error: 'r' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> sound/mips/hal2.c:223:35: error: 'l' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> sound/mips/hal2.c: In function 'hal2_gain_put':
> sound/mips/hal2.c:260:13: error: 'new' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> sound/mips/hal2.c:260:13: error: 'old' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> Returning an error for all unexpected cases shuts up the warning
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v3: actually send the correct patch, sorry for the mixup
> v2: return an error instead trying to handle gracefully

Thanks, applied now.


Takashi