linux-kernel - Re: [PATCH 1/1] x86/rtc: Allocate interrupt for platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484578496.2133.147.camel@linux.intel.com>
Date:   Mon, 16 Jan 2017 16:54:56 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: Re: [PATCH 1/1] x86/rtc: Allocate interrupt for platform device

On Mon, 2017-01-16 at 22:46 +0800, kbuild test robot wrote:
> Hi Andy,
> 
> [auto build test ERROR on tip/auto-latest]
> [also build test ERROR on v4.10-rc4 next-20170116]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/x86-r
> tc-Allocate-interrupt-for-platform-device/20170116-222720
> config: x86_64-randconfig-x011-201703 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    arch/x86/kernel/rtc.c: In function 'add_rtc_cmos':
> > > arch/x86/kernel/rtc.c:202:2: error: implicit declaration of
> > > function 'ioapic_set_alloc_attr' [-Werror=implicit-function-
> > > declaration]
> 
>      ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1, 0);
>      ^~~~~~~~~~~~~~~~~~~~~
> > > arch/x86/kernel/rtc.c:203:8: error: implicit declaration of
> > > function 'mp_map_gsi_to_irq' [-Werror=implicit-function-
> > > declaration]
> 
>      ret = mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info);
>            ^~~~~~~~~~~~~~~~~
> > > arch/x86/kernel/rtc.c:203:35: error: 'IOAPIC_MAP_ALLOC' undeclared
> > > (first use in this function)
> 
>      ret = mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info);
>                                       ^~~~~~~~~~~~~~~~
>    arch/x86/kernel/rtc.c:203:35: note: each undeclared identifier is
> reported only once for each function it appears in
>    cc1: some warnings being treated as errors

Hmm... Perhaps nice catch. I would check what I have missed, though I
even tested this change on two platforms.

> 
> vim +/ioapic_set_alloc_attr +202 arch/x86/kernel/rtc.c
> 
>    196			}
>    197		}
>    198	#endif
>    199		if (!x86_platform.legacy.rtc)
>    200			return -ENODEV;
>    201	
>  > 202		ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1,
> 0);
>  > 203		ret = mp_map_gsi_to_irq(RTC_IRQ,
> IOAPIC_MAP_ALLOC, &info);
>    204		if (ret < 0)
>    205			return ret;
>    206	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy