lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 16 Jan 2017 10:38:42 -0500
From:   Stefan Berger <stefanb@...ux.vnet.ibm.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     tpmdd-devel@...ts.sourceforge.net,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] tpm: Check size of response before accessing data

On 01/16/2017 08:25 AM, Jarkko Sakkinen wrote:
> On Mon, Jan 16, 2017 at 03:24:09PM +0200, Jarkko Sakkinen wrote:
>> On Fri, Jan 13, 2017 at 09:36:34PM -0500, Stefan Berger wrote:
>>> Make sure that we have not received less bytes than what is indicated
>>> in the header of the TPM response. Also, check the number of bytes in
>>> the response before accessing its data.
>>>
>>> Signed-off-by: Stefan Berger <stefanb@...ux.vnet.ibm.com>
>> There are some things that I want to comment after all but I can give
>> now
>>
>> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
>>
>> I also noticed that this patch is not CC'd to linux-kernel.
> Please go through the whole patch and remove arithmetic
> from every possible place where you only end up with a
> constant.

sizeof(cap.timeout) -- what do you want to do about that? Is that 
legitimate or do you want a number then??? What about offsetof's?


Powered by blists - more mailing lists