linux-kernel - Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Jan 2017 09:45:57 -0600
From:   Rob Herring <robh@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Nishanth Menon <nm@...com>, Lokesh Vutla <lokeshvutla@...com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check
 on unsigned int

On Fri, Jan 13, 2017 at 3:06 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redundant. Remove the check and the associated
> dev_err error message.

Not sure why I got copied on this...

> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------

This file doesn't exist in mainline.

>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> index 3b86d3d..a345166 100644
> --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
>         r = iod->reg_data;
>
>         offset = ti_iodelay_pin_to_offset(iod, pin);
> -       if (pin < 0) {

Shouldn't this be "if (offset < 0)"?


> -               dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
> -
> -               return;
> -       }
> -
>         pd = &iod->pa[pin];
>         cfg = pd->drv_data;
>
> --
> 2.10.2
>